NAS-133586 / 25.04 / Fix domain join in Samba 4.21 #15402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bugclerk
changed the title
bmeagherix
approved these changes
Jan 15, 2025
src/middlewared/middlewared/plugins/directoryservices_/activedirectory_join_mixin.py
Show resolved
Hide resolved
mgrimesix
reviewed
Jan 15, 2025
mgrimesix
reviewed
Jan 15, 2025
mgrimesix
approved these changes
Jan 15, 2025
Various winbind / libads parameters and commands changed in samba 4.21 and so we need to adjust.
anodos325
force-pushed
the
fix-domain-join
branch
from
48e23d2 to
f319621
Compare
|
This PR has been merged and conversations have been locked. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Various winbind / libads parameters and commands changed in samba 4.21 and so we need to adjust.